Skip to content

Honor sys.int_max_str_digits in native json.loads #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Federicorao wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −4
Open

Honor sys.int_max_str_digits in native json.loads #8087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16679d3
Honor int_max_str_digits in native JSON scanner
Federicorao Jun 12, 2026
2707f54
Fix JSON int limit CI failures
Federicorao Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions crates/stdlib/src/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,11 @@ mod _json {
builtins::{PyBaseExceptionRef, PyStrRef, PyType},
convert::ToPyResult,
function::{IntoFuncArgs, OptionalArg},
protocol::PyIterReturn,
protocol::{handle_bytes_to_int_err, PyIterReturn},
types::{Callable, Constructor},
};
use core::str::FromStr;
use malachite_bigint::BigInt;
use rustpython_common::wtf8::Wtf8Buf;
use rustpython_common::{int::bytes_to_int, wtf8::Wtf8Buf};
use std::collections::HashMap;

/// Skip JSON whitespace characters (space, tab, newline, carriage return).
Expand Down Expand Up @@ -243,7 +242,12 @@ mod _json {
} else if let Some(ref parse_int) = self.parse_int {
parse_int.call((buf,), vm)
} else {
Ok(vm.new_pyobj(BigInt::from_str(buf).unwrap()))
bytes_to_int(buf.as_bytes(), 10, vm.state.int_max_str_digits.load())
.map(|value| vm.new_pyobj(value))
.map_err(|e| {
let obj = vm.ctx.new_str(buf);
handle_bytes_to_int_err(e, obj.as_object(), vm)
})
};
Some((ret, buf.len()))
}
Expand Down
13 changes: 13 additions & 0 deletions extra_tests/snippets/stdlib_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
import sys
from io import BytesIO, StringIO

from testutils import assert_raises
Expand Down Expand Up @@ -261,3 +262,15 @@ def assert_no_native_stack_overflow(func):
assert e.pos == 5, f"expected pos=5, got {e.pos}"
else:
raise AssertionError("expected JSONDecodeError")

# Test that json.loads honors sys.int_max_str_digits
_min_limit = sys.int_info.str_digits_check_threshold
_orig_limit = sys.get_int_max_str_digits()
try:
sys.set_int_max_str_digits(_min_limit)
with assert_raises(ValueError):
json.loads("1" * (_min_limit + 1))
assert json.loads("1" * _min_limit) == int("1" * _min_limit)
assert json.loads('42') == 42
finally:
sys.set_int_max_str_digits(_orig_limit)
Loading