Skip to content

fix(devtools): clarify disabled View Source tooltip and update demo app - #70053

Open
AleksanderBodurri wants to merge 2 commits into
angular:mainfrom
AleksanderBodurri:fix-signal-graph-view-source
Open

fix(devtools): clarify disabled View Source tooltip and update demo app #70053
AleksanderBodurri wants to merge 2 commits into
angular:mainfrom
AleksanderBodurri:fix-signal-graph-view-source

Conversation

@AleksanderBodurri

@AleksanderBodurri AleksanderBodurri commented Aug 3, 2026

Copy link
Copy Markdown
Member

Depends on #70052

Before: The View Source button tooltip in signal details static ('View source') even when disabled and disabled styling does not apply

After: The tooltip explains 'Source location is not available for this node' when disabled and disabled styling is applied

@pullapprove
pullapprove Bot requested a review from JeanMeche August 3, 2026 02:41
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime area: devtools labels Aug 3, 2026
@ngbot ngbot Bot added this to the Backlog milestone Aug 3, 2026
@AleksanderBodurri AleksanderBodurri changed the title Fix signal graph view source fix(devtools): clarify disabled View Source tooltip and update demo app Aug 3, 2026
@AleksanderBodurri
AleksanderBodurri force-pushed the fix-signal-graph-view-source branch from dc57e83 to eaa28b0 Compare August 10, 2026 03:33
Before: getSignalGraph only exposed debuggableFn on computed and template
nodes, preventing DevTools from linking to source code for other node types.

After: debuggableFn is also populated for linkedSignal, effect, and
afterRenderEffectPhase nodes.
@JeanMeche
JeanMeche force-pushed the fix-signal-graph-view-source branch from eaa28b0 to c5e6dfa Compare August 16, 2026 18:41
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 16, 2026
Before: The View Source button tooltip in signal details static ('View source') even when disabled.

After: The tooltip explains 'Source location is not available for this node' when disabled.
@JeanMeche
JeanMeche force-pushed the fix-signal-graph-view-source branch from c5e6dfa to 1b0d8ff Compare August 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: devtools target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants