Improve heuristics to parse out sccache errors and ignore unhelpful errors - #6845
Open
Karakatiza666 wants to merge 1 commit into
Open
Improve heuristics to parse out sccache errors and ignore unhelpful errors#6845Karakatiza666 wants to merge 1 commit into
Karakatiza666 wants to merge 1 commit into
Conversation
…re unhelpful errors Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
mihaibudiu
approved these changes
Aug 12, 2026
| // which would otherwise let $ match at every line break. | ||
| const rustCompilerErrorRegex = | ||
| /^((warning:(?! `)|error(\[[\w]+\])?:)([\s\S])+?)\n(\n|(?=error|warning))/gm | ||
| /^((?:[\w-]+: )?(warning:(?! `)|error(\[[\w]+\])?:)([\s\S])+?)(\n(\n|(?=error|warning))|\n?$(?![\s\S]))/gm |
Contributor
There was a problem hiding this comment.
This should be a constant with comments about each part and perhaps an example matched
| expect(errors[0].message.split('\n')).toHaveLength(3) | ||
| }) | ||
|
|
||
| it('ignores black-listed warnings', () => { |
Contributor
There was a problem hiding this comment.
I don't know where the blacklisted part lives, but it better be conservative. Here you want no false negatives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: sccache error message parsing tested with unit tests, general behavior of parsing out error messages from stderr checked manually (no messages skipped, except unhelpful ones like "build failed due to X previous errors").
Part of #6763