[python] Drop unoptimized profile from platform config tests - #6874
Open
gz wants to merge 1 commit into
Open
Conversation
CI compilers precompile dependencies only for the default optimized profile. A test pipeline requesting profile=unoptimized with cache=false forced a cold build of the full dependency tree (~4 minutes) that serially blocked every other queued Rust build on its compiler replica, timing out unrelated tests under parallel load. test_pipeline_runtime_config created that pipeline and never used it: the subsequent PATCH targets the first pipeline. Delete the dead creation. test_pipeline_program_config asserts a non-default profile round-trips; 'dev' covers that and its SQL never compiles, so no Rust build runs either way. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz
enabled auto-merge
August 16, 2026 19:52
mihaibudiu
approved these changes
Aug 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI compilers precompile dependencies only for the default
optimizedprofile. A platform test pipeline requestingprofile: unoptimizedwithcache: falseforced a cold build of the full dependency tree (~4 minutes) that serially blocked every other queued Rust build on its compiler replica. Under parallel test load that backlog consumed the start timeout of unrelated tests and made them flake.Changes in
python/tests/platform/test_pipeline_configs.py:test_pipeline_runtime_config: delete the second pipeline creation. It carried theunoptimized+cache: falseconfig, its SQL compiled (comment-only program), and nothing ever read it back: the subsequent PATCH and all assertions target the first pipeline. Dead code whose only observable effect was the queue-hogging build.test_pipeline_program_config: assert the profile round-trip withdevinstead ofunoptimized. The test's SQL intentionally fails to compile, so no Rust build runs either way;devstill exercises a non-default profile through PUT/PATCH.No test under
tests/platformsetsunoptimizedanymore.