DOC: make championing pr standalone subsection and update alert procedure - #32185
Open
story645 wants to merge 1 commit into
Open
DOC: make championing pr standalone subsection and update alert procedure#32185story645 wants to merge 1 commit into
story645 wants to merge 1 commit into
Conversation
melissawm
reviewed
Aug 11, 2026
| weekly development meeting, the development channel on discourse and the dev mailing | ||
| list. Other core devs can then either review the PR and merge or reject it, or simply | ||
| request that it gets a second review before being merged. If no one asks for such a | ||
| second review within a week, the PR can then be merged on the basis of that single |
Member
There was a problem hiding this comment.
Can we be explicit and say
Suggested change
| second review within a week, the PR can then be merged on the basis of that single | |
| second review within a week, the PR can then be merged by any maintainer on the basis of that single |
Just to clarify we don't necessarily need to wait for the champion to do it. (Also, I'm using maintainer as an umbrella for core dev/other roles in the project but feel free to use core dev everywhere if that's more precise here.)
Member
Author
There was a problem hiding this comment.
Maintainer is accurate - anyone with commit rights can merge
Member
Author
There was a problem hiding this comment.
Which I should update the whole paragraph with maintainer. We don't really have a distinction at the moment, though maybe we should
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Follow up to #32113, pulls language about championing PRs into a subsection to make extra clear that it applies to doc and code PRs. Also updates the alert/contact, but I think we have too many and should maybe pull back to:
AI Disclosure
nopes
PR quality check