Shutdown process normally if possible - #579
Merged
Merged
Conversation
Dave Syer (dsyer)
requested review from
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
January 27, 2025 15:43
Dave Syer (dsyer)
force-pushed
the
main
branch
from
January 28, 2025 16:29
2c1ea02 to
d8b7654
Compare
Contributor
Author
|
What can I do to move this forward? Julien Dubois (@jdubois) can you help over there? |
|
Hey Dave Syer (@dsyer) ! I'm pinging Jinbo Wang (@testforstephen) |
Jinbo Wang (testforstephen)
approved these changes
Feb 28, 2025
Jinbo Wang (testforstephen)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. thanks.
Contributor
|
Dave Syer (@dsyer) I fixed the CI failure in main branch, could you sync your branch based on the main branch? |
Dave Syer (dsyer)
force-pushed
the
main
branch
from
February 28, 2025 06:24
d8b7654 to
9ac979a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-java-debug#1274