chore(sqlserverflex): Deprecate fields, flags and commands - #1535
Open
Fyusel wants to merge 1 commit into
Open
Conversation
Fyusel
force-pushed
the
sqlserverflex-deprecate-fields
branch
from
August 17, 2026 09:33
b2b0b1f to
aabaa8c
Compare
STACKITCLI-436 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
sqlserverflex-deprecate-fields
branch
from
August 17, 2026 09:34
aabaa8c to
c6a71e9
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| `Create a SQLServer Flex instance with name "my-instance", specify flavor by CPU and RAM, set storage size to 20 GB, and restrict access to a specific range of IP addresses. Other parameters are set to default values`, | ||
| `$ stackit beta sqlserverflex instance create --name my-instance --cpu 1 --ram 4 --storage-size 20 --backup-schedule "0 1-3 * * *" --retention-days 30 --storage-class premium-perf2-stackit --storage-size 10 --version 2022 --acl 1.2.3.0/24`), | ||
| `Create a SQLServer Flex instance with name "my-instance", specify flavor by ID, set storage size to 20 GB, and restrict access to a specific range of IP addresses. Other parameters are set to default values`, | ||
| `$ stackit beta sqlserverflex instance create --name my-instance --flavor-id xxx --storage-size 20 --backup-schedule "0 2 * * *" --retention-days 30 --storage-class premium-perf2-stackit --storage-size 10 --version 2022 --acl 1.2.3.0/24`), |
Contributor
There was a problem hiding this comment.
--storage-size is set twice in this example
| @@ -72,11 +78,11 @@ | |||
| Example: examples.Build( | |||
| examples.NewExample( | |||
| `Create a SQLServer Flex instance with name "my-instance" and specify flavor by ID. Other parameters are set to default values. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| `Create a SQLServer Flex instance with name "my-instance" and specify flavor by ID. Other parameters are set to default values. | |
| `Create a SQLServer Flex instance with name "my-instance" and specify flavor by ID. |
| cmd.Flags().String(encryptionKekKeyVersionFlag, "", "The key version") | ||
| cmd.Flags().String(encryptionServiceAccountFlag, "", "The service account") | ||
|
|
||
| err := flags.MarkFlagsRequired(cmd, instanceNameFlag, backupScheduleFlag, retentionDaysFlag, storageClassFlag, storageSizeFlag, versionFlag) |
Contributor
There was a problem hiding this comment.
It looks like ACL should be required as well here, as it is required by the API
Comment on lines
+37
to
+41
| Example: examples.Build( | ||
| examples.NewExample( | ||
| `List SQLServer Flex flavors`, | ||
| "$ stackit beta sqlserverflex flavor list"), | ||
| ), |
Contributor
There was a problem hiding this comment.
we should also add a example using the --limit flag here
Comment on lines
+42
to
+49
| Example: examples.Build( | ||
| examples.NewExample( | ||
| `List SQLServer Flex database compatibilities of instance with ID "xxx"`, | ||
| "$ stackit beta sqlserverflex db-compatibility list --instance-id xxx"), | ||
| examples.NewExample( | ||
| `List SQLServer Flex database compatibilities of instance with ID "xxx" in JSON format`, | ||
| "$ stackit beta sqlserverflex db-compatibility list --instance-id xxx --output-format json"), | ||
| ), |
Contributor
There was a problem hiding this comment.
missing limit example
Comment on lines
+42
to
+49
| Example: examples.Build( | ||
| examples.NewExample( | ||
| `List SQLServer Flex database collations of instance with ID "xxx"`, | ||
| "$ stackit beta sqlserverflex db-collation list --instance-id xxx"), | ||
| examples.NewExample( | ||
| `List SQLServer Flex database collations of instance with ID "xxx" in JSON format`, | ||
| "$ stackit beta sqlserverflex db-collation list --instance-id xxx --output-format json"), | ||
| ), |
Contributor
There was a problem hiding this comment.
missing limit example
| storageClassesTable.AddSeparator() | ||
| } | ||
|
|
||
| return tables.DisplayTables(p, []tables.Table{table, storageClassesTable}) |
Contributor
There was a problem hiding this comment.
Nitpick: other commands wrap the potentially occuring error here like this:
err := table.Display(p)
if err != nil {
return fmt.Errorf("render table: %w", err)
}
return nilhere the error is directly returned so we do not have the render table hint.
This nitpick is also applicable for db-collation, db-compatibility and user-role
Comment on lines
+41
to
+48
| Example: examples.Build( | ||
| examples.NewExample( | ||
| `List SQLServer Flex user roles of instance with ID "xxx"`, | ||
| "$ stackit beta sqlserverflex user-role list --instance-id xxx"), | ||
| examples.NewExample( | ||
| `List SQLServer Flex user roles of instance with ID "xxx" in JSON format`, | ||
| "$ stackit beta sqlserverflex user-role list --instance-id xxx --output-format json"), | ||
| ), |
Contributor
There was a problem hiding this comment.
missing limit example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITCLI-436
Description
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)