ROX-36101: Node reports list view - #22320
Conversation
| ): CancellableRequest<{ count: number }> { | ||
| const params = queryString.stringify( | ||
| { query: getRequestQueryStringForSearchFilter(searchFilter) }, | ||
| { arrayFormat: 'repeat' } |
There was a problem hiding this comment.
I think a getCountQueryParams as a util function next to getListQueryParams in searchUtils is worth a follow up. There are 4 other services doing the exact same thing as this one, and a few others doing something similar that I think could also benefit.
| <PageSection> | ||
| <Toolbar> | ||
| <ToolbarContent> | ||
| <ToolbarItem className="pf-v6-u-flex-grow-1"> |
There was a problem hiding this comment.
No way around this unfortunately without dropping the Toolbar component itself
🚀 Build Images ReadyImages are ready for commit 954dbea. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-778-g954dbeaca9 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bradr/ROX-36100_node_reports_page_scaffolding #22320 +/- ##
==============================================================================
Coverage 51.19% 51.20%
==============================================================================
Files 2855 2855
Lines 178712 178712
==============================================================================
+ Hits 91499 91501 +2
+ Misses 79130 79129 -1
+ Partials 8083 8082 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Node vulnerability reports list view
Notes:
ReportsService.types.tsthat were incomplete (ResourceScopemissingentityScope,SchedulemissingDAILY), confirmed unused in image reports, but matches proto 1:1.useCallback+useRestQueryandgetTableUIState/TbodyUnifiedrather thancopying the sibling image reports.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Backend doesn't exist yet, so no e2e validation against real data. Confirmed to work against mock data:
